This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Stop telling people to install the optional dependencies. #5197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They're optional. Also update the postgres docs a bit for clarity(?)
3 tasks
|
pinging @erikjohnston and @hawkowl in case they have strong opinions here. |
Codecov Report
@@ Coverage Diff @@
## master #5197 +/- ##
==========================================
- Coverage 61.75% 61.75% -0.01%
==========================================
Files 336 336
Lines 34639 34639
Branches 5692 5692
==========================================
- Hits 21391 21390 -1
- Misses 11720 11721 +1
Partials 1528 1528 |
hawkowl
approved these changes
May 16, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They're optional.
Also update the postgres docs a bit for clarity(?)
Fixes #5168